Horton

Re: pg_stat_statements: Avoid holding excessive lock

Karina Litskevich <litskevichkarina@gmail.com>

View thread View on postgr.es
From: Karina Litskevich <litskevichkarina@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2024-11-07T13:08:30Z
Lists: pgsql-hackers

Attachments

On Thu, Nov 7, 2024 at 11:17 AM Michael Paquier <michael@paquier.xyz> wrote:
> The comment could be simpler, say a "The spinlock is not required when
> reading these two as they are always updated when holding pgss->lock
> exclusively.".  Or something like that.

Thank you for your feedback and the shorter wording of the comment.
I used it in the new version of the patch.

Best regards,
Karina Litskevich
Postgres Professional: http://postgrespro.com/

Commits

  1. pg_stat_statements: Avoid some locking during PGSS entry scans