Re: [PATCH] Improve amcheck to also check UNIQUE constraint in btree index.

Karina Litskevich <litskevichkarina@gmail.com>

From: Karina Litskevich <litskevichkarina@gmail.com>

To: Pavel Borisov <pashkin.elfe@gmail.com>

Cc: Alexander Korotkov <aekorotkov@gmail.com>, Peter Eisentraut <peter@eisentraut.org>, Aleksander Alekseev <aleksander@timescale.com>, Postgres hackers <pgsql-hackers@lists.postgresql.org>, Maxim Orlov <orlovmg@gmail.com>, Andres Freund <andres@anarazel.de>, Greg Stark <stark@mit.edu>, Julien Rouhaud <rjuju123@gmail.com>, Mark Dilger <mark.dilger@enterprisedb.com>, David Steele <david@pgmasters.net>, Peter Geoghegan <pg@bowt.ie>, Maxim Orlov <m.orlov@postgrespro.ru>, lubennikovaav@gmail.com

Date: 2024-04-25T13:44:19Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

amcheck: Optimize speed of checking for unique constraint violation
- cdd6ab9d1f53 18.0 landed
amcheck: Report an error when the next page to a leaf is not a leaf
- 97e5b0026fc2 17.0 landed
amcheck: Don't load the right sibling page into BtreeCheckState
- 0b5c16124811 17.0 landed
amcheck: Refactoring the storage of the last visible entry
- 532d94fec32a 17.0 landed
Teach contrib/amcheck to check the unique constraint violation
- 5ae2087202af 17.0 landed
Add macros in hash and btree AMs to get the special area of their pages
- d16773cdc862 15.0 cited

Hi, hackers!

On Thu, Apr 25, 2024 at 4:00 PM Pavel Borisov <pashkin.elfe@gmail.com>
wrote:

> 0005: Rename checkunique parameter to more user friendly as proposed by
> Peter Eisentraut and Alexander Korotkov
>

I'm not sure renaming checkunique is a good idea. Other arguments of
bt_index_check and bt_index_parent_check functions (heapallindexed and
rootdescend) don't have underscore character in them. Corresponding
pg_amcheck options (--heapallindexed and --rootdescend) are also written
in one piece. check_unique and --check-unique stand out. Making arguments
and options in different styles doesn't seem user friendly to me.

Best regards,
Karina Litskevich
Postgres Professional: http://postgrespro.com/