Horton

Thread

Commits

  1. doc: Add note about I/O timing information in EXPLAIN and pg_stat_database.

  1. Add explanations which are influenced by track_io_timing

    Atsushi Torikoshi <atorik@gmail.com> — 2020-05-13T12:54:27Z

    Hi,

When track_io_timing is on, I/O timing information is
displayed in pg_stat_database, in the output of EXPLAIN
when the BUFFERS option is used, and in pg_stat_statements
as documented in [1].

This is also described in the manual for pg_stat_statements
[2], however, manuals for pg_stat_database and EXPLAIN
doesn't refer to it.

I think it'll be better to add descriptions to both of them
for consistency.

Thoughts?


[1]
https://www.postgresql.org/docs/devel/runtime-config-statistics.html#GUC-TRACK-IO-TIMING
[2]
https://www.postgresql.org/docs/devel/pgstatstatements.html#PGSTATSTATEMENTS-COLUMNS

Regards,

--
Atsushi Torikoshi

  2. Re: Add explanations which are influenced by track_io_timing

    Fujii Masao <masao.fujii@oss.nttdata.com> — 2020-05-13T14:27:30Z

    
On 2020/05/13 21:54, Atsushi Torikoshi wrote:
> Hi,
> 
> When track_io_timing is on, I/O timing information is
> displayed in pg_stat_database, in the output of EXPLAIN
> when the BUFFERS option is used, and in pg_stat_statements
> as documented in [1].
> 
> This is also described in the manual for pg_stat_statements
> [2], however, manuals for pg_stat_database and EXPLAIN
> doesn't refer to it.
> 
> I think it'll be better to add descriptions to both of them
> for consistency.
> 
> Thoughts?


+1

+      in milliseconds(if <xref linkend="guc-track-io-timing"/> is enabled,
+      otherwise zero)

It's better to add a space character just after "seconds".

-      written.
+      written. In addition, If <xref linkend="guc-track-io-timing"/> is enabled,
+      also include I/O Timings.

Isn't it better to just use clearer description like "the time reading and
writing data blocks" here instead of "I/O Timing"?
What about the attached patch based on yours?

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

  3. Re: Add explanations which are influenced by track_io_timing

    Atsushi Torikoshi <atorik@gmail.com> — 2020-05-15T00:50:41Z

    Thanks for reviewing!

On Wed, May 13, 2020 at 11:27 PM Fujii Masao <masao.fujii@oss.nttdata.com>
wrote:

> What about the attached patch based on yours?


It looks better.

Regards,

--
Atsushi Torikoshi

  4. Re: Add explanations which are influenced by track_io_timing

    Fujii Masao <masao.fujii@oss.nttdata.com> — 2020-05-22T14:37:39Z

    
On 2020/05/15 9:50, Atsushi Torikoshi wrote:
> Thanks for reviewing!
> 
> On Wed, May 13, 2020 at 11:27 PM Fujii Masao <masao.fujii@oss.nttdata.com <mailto:masao.fujii@oss.nttdata.com>> wrote:
> 
>     What about the attached patch based on yours?
> 
> 
> It looks better.

Pushed. Thanks!

Regards,

-- 
Fujii Masao
Advanced Computing Technology Center
Research and Development Headquarters
NTT DATA CORPORATION

  5. Re: Add explanations which are influenced by track_io_timing

    Atsushi Torikoshi <atorik@gmail.com> — 2020-05-25T01:57:17Z

    On Fri, May 22, 2020 at 11:37 PM Fujii Masao <masao.fujii@oss.nttdata.com>
wrote:

>
>
> On 2020/05/15 9:50, Atsushi Torikoshi wrote:
> > Thanks for reviewing!
> >
> > On Wed, May 13, 2020 at 11:27 PM Fujii Masao <
> masao.fujii@oss.nttdata.com <mailto:masao.fujii@oss.nttdata.com>> wrote:
> >
> >     What about the attached patch based on yours?
> >
> >
> > It looks better.
>
> Pushed. Thanks!
>

Thanks for reviewing and improvements!

Regards,

--
Atsushi Torikoshi