Horton

Re: Pgstattuple on Sequences: Seeking Community Feedback on Potential Patch

Ayush Vatsa <ayushvatsa1810@gmail.com>

View thread View on postgr.es
From: Ayush Vatsa <ayushvatsa1810@gmail.com>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Robert Haas <robertmhaas@gmail.com>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>, michael@paquier.xyz
Date: 2024-08-29T18:47:47Z
Lists: pgsql-hackers

Attachments

> I'm concerned that some of this might be platform-dependent and make the
> test unstable.  Perhaps we should just select count(*) here.
> Sure enough, the CI testing for 32-bit is failing here [0].
Thanks for catching that! I wasn't aware of this earlier.

> I think we should be a bit more descriptive here
Regarding the comment, I've tried to make it more
descriptive and simpler than the existing one in
verify_heapam.c. Here’s the comment I propose:

/*
 * Sequences implicitly use the heap AM, even though it's not explicitly
 * recorded in the catalogs. For other relation kinds, verify that the AM
 * is heap; otherwise, raise an error.
 */

Please let me know if this still isn’t clear enough,
then I can make further revisions in line with verify_heapam.c.

The patch with all the changes is attached.

Regards
Ayush Vatsa
AWS

Commits

  1. Fix contrib/pageinspect's test for sequences.

  2. Reintroduce support for sequences in pgstattuple and pageinspect.

  3. Only allow heap in a number of contrib modules.