Re: BUG #19095: Test if function exit() is used fail when linked static

Hi Daniel, Michael,Nazir

Thanks for the feedback.

For v4 I will implement the approach you outlined:

  -Move the nm detection to the top-level build:
      - Add find_program('nm') in the root meson.build
      - Add PGAC_CHECK_PROG(NM_PROG, nm) in configure.ac
    and export the result down into src/interfaces/libpq for use by both
    Meson and Makefile builds.

  -Pass the resolved nm path into libpq-exit-check via a --nm argument,
    removing the internal which nm lookup from the script.

  -Expand the platform skip logic in the script to include Windows in
    addition to Solaris, and close the filehandle as suggested.

  -Replace the comments in Makefile and meson.build with the unified
    explanatory block, and keep all platform details inside the script.

I will post v4 with these changes shortly.

Regards,
Vasuki

On Wed, 26 Nov 2025 at 09:13, Michael Paquier <michael@paquier.xyz> wrote:

> On Tue, Nov 25, 2025 at 11:51:55AM +0100, Daniel Gustafsson wrote:
> > +if find_program('nm', required: false, native: true).found() and not
> get_option('b_coverage')
> > Sorry for being late to the party, but I wonder why we aren't adding
> this check
> > to the toplevel meson.build and configure.ac (via config/programs.m4)
> like how
> > we check for all others tools used by the build?  Such checks should of
> course
> > not fail the configuration, merely record the presence or absence of the
> tool.
> > The path can then be exported to
> src/interfaces/libpq/{Makefile|meson.build} to
> > use.
>
> +1 for this find_program() call grouped at the top of meson.build,
> grouped with the others.
> --
> Michael
>