Horton

Re: Unhappy about API changes in the no-fsm-for-small-rels patch

John Naylor <john.naylor@2ndquadrant.com>

View thread View on postgr.es
From: John Naylor <john.naylor@2ndquadrant.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Andres Freund <andres@anarazel.de>, Tom Lane <tgl@sss.pgh.pa.us>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2019-04-26T05:18:09Z
Lists: pgsql-hackers 
On Fri, Apr 26, 2019 at 11:52 AM Amit Kapila <amit.kapila16@gmail.com> wrote:
>
> On Thu, Apr 25, 2019 at 12:39 PM John Naylor
> <john.naylor@2ndquadrant.com> wrote:
> >
> > On Wed, Apr 24, 2019 at 1:58 PM Amit Kapila <amit.kapila16@gmail.com> wrote:
> > > <v2 patch>
> >
> > Sorry for not noticing earlier, but this patch causes a regression
> > test failure for me (attached)
> >
>
> Can you please try to finish the remaining work of the patch (I am bit
> tied up with some other things)?  I think the main thing apart from
> representation of map as one-byte or one-bit per block is to implement
> invalidation.   Also, try to see if there is anything pending which I
> might have missed.  As discussed above, we need to issue an
> invalidation for following points:  (a) when vacuum finds there is no
> FSM and page has more space now, I think you can detect this in
> RecordPageWithFreeSpace (b) invalidation to notify the existence of
> FSM, this can be done both by vacuum and backend.

Yes, I'll work on it.

-- 
John Naylor                https://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Commits

  1. Revert "Avoid the creation of the free space map for small heap relations".

  2. Improve code comments in b0eaa4c51b.

  3. During pg_upgrade, conditionally skip transfer of FSMs.

  4. Add more tests for FSM.

  5. Fix typos in commit 8586bf7ed8.

  6. tableam: introduce table AM infrastructure.

  7. Clear the local map when not used.

  8. Doc: Update the documentation for FSM behavior for small tables.

  9. Make FSM test portable.

  10. Avoid creation of the free space map for small heap relations, take 2.