Re: [PATCH] Don't call ereport(ERROR) from recovery target GUC assign hooks

JoongHyuk Shin <sjh910805@gmail.com>

From: JoongHyuk Shin <sjh910805@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Zsolt Parragi <zsolt.parragi@percona.com>, pgsql-hackers@lists.postgresql.org
Date: 2026-07-06T07:53:44Z
Lists: pgsql-hackers
On Mon, Jun 29, 2026 at 04:16:59PM -0500, Zsolt Parragi wrote:
> Isn't mentioning pg_settings confusing instead of helpful during a
> server restart? With a reload it can help, but when the server can't
> start, hinting that the user should query pg_settings doesn't seem
> that useful.

You're right, and I had missed this.  Thanks.

I would rather drop the errhint from this patch entirely than fold it into
the errdetail.
Any objections?

-- 
JH Shin