Re: Speed dblink using alternate libpq tuple storage
Marko Kreen <markokr@gmail.com>
From: Marko Kreen <markokr@gmail.com>
To: Marc Mamin <M.Mamin@intershop.de>
Cc: Kyotaro HORIGUCHI <horiguchi.kyotaro@oss.ntt.co.jp>, pgsql-hackers@postgresql.org, greg@2ndquadrant.com
Date: 2012-01-23T11:17:49Z
Lists: pgsql-hackers
On Sat, Jan 21, 2012 at 1:52 PM, Marc Mamin <M.Mamin@intershop.de> wrote: >> > >> > c. Refine error handling of dblink.c. I think it preserves the >> > previous behavior for column number mismatch and type >> > conversion exception. > > Hello, > > I don't know if this cover following issue. > I just mention it for the case you didn't notice it and would like to > handle this rather cosmetic issue as well. > > http://archives.postgresql.org/pgsql-bugs/2011-08/msg00113.php It is not relevant to this thread, but seems good idea to implement indeed. It should be simple matter of creating handler that uses dblink_res_error() to report the notice. Perhaps you could create and submit the patch by yourself? For reference, here it the full flow in PL/Proxy: 1) PQsetNoticeReceiver: https://github.com/markokr/plproxy-dev/blob/master/src/execute.c#L422 2) handle_notice: https://github.com/markokr/plproxy-dev/blob/master/src/execute.c#L370 3) plproxy_remote_error: https://github.com/markokr/plproxy-dev/blob/master/src/main.c#L82 -- marko