Re: Check for existing replication slot in pg_createsubscriber

Zane Duffield <duffieldzane@gmail.com>

From: Zane Duffield <duffieldzane@gmail.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: pgsql-hackers@postgresql.org
Date: 2025-06-30T03:23:10Z
Lists: pgsql-hackers
On Mon, Jun 30, 2025 at 1:15 PM Amit Kapila <amit.kapila16@gmail.com> wrote:

> One thing I was
> thinking is whether it makes sense to add these checks only in
> --dry-run mode because we normally don't expect such conflicts.
> Otherwise, each such check adds an additional network round-trip.
>

I did wonder why it bothered checking for conflicts before running the
command that would fail in case of a conflict.
It makes sense to me to only check for conflicts in --dry-run mode.

Thanks,
Zane