Horton

Thread

Commits

  1. Remove duplicate line

  2. SQL/JSON: Improve error-handling of JsonBehavior expressions

  1. duplicate line in ExecEvalJsonCoercionFinish

    jian he <jian.universality@gmail.com> — 2025-07-16T23:38:54Z

    hi.

ExecEvalJsonCoercionFinish duplicate line:
        jsestate->escontext.error_occurred = false;
        jsestate->escontext.error_occurred = false;

https://git.postgresql.org/cgit/postgresql.git/tree/src/backend/executor/execExprInterp.c#n5230

  2. Re: duplicate line in ExecEvalJsonCoercionFinish

    Tender Wang <tndrwang@gmail.com> — 2025-07-17T00:51:44Z

    jian he <jian.universality@gmail.com> 于2025年7月17日周四 07:39写道：

> hi.
>
> ExecEvalJsonCoercionFinish duplicate line:
>         jsestate->escontext.error_occurred = false;
>         jsestate->escontext.error_occurred = false;
>
>
> https://git.postgresql.org/cgit/postgresql.git/tree/src/backend/executor/execExprInterp.c#n5230


Good catch.  It was introduced by this commit 231b7d670b21.
Add Amit to the cc list.

-- 
Thanks,
Tender Wang

  3. Re: duplicate line in ExecEvalJsonCoercionFinish

    Richard Guo <guofenglinux@gmail.com> — 2025-07-17T01:01:26Z

    On Thu, Jul 17, 2025 at 9:52 AM Tender Wang <tndrwang@gmail.com> wrote:
> jian he <jian.universality@gmail.com> 于2025年7月17日周四 07:39写道：
>> ExecEvalJsonCoercionFinish duplicate line:
>>         jsestate->escontext.error_occurred = false;
>>         jsestate->escontext.error_occurred = false;

> Good catch.  It was introduced by this commit 231b7d670b21.
> Add Amit to the cc list.

Nice catch!  The two duplicate statements were introduced in separate
commits; looks like a copy-paste oversight in the later one.

Thanks
Richard

  4. Re: duplicate line in ExecEvalJsonCoercionFinish

    Amit Langote <amitlangote09@gmail.com> — 2025-07-17T03:03:14Z

    On Thu, Jul 17, 2025 at 10:01 AM Richard Guo <guofenglinux@gmail.com> wrote:
> On Thu, Jul 17, 2025 at 9:52 AM Tender Wang <tndrwang@gmail.com> wrote:
> > jian he <jian.universality@gmail.com> 于2025年7月17日周四 07:39写道：
> >> ExecEvalJsonCoercionFinish duplicate line:
> >>         jsestate->escontext.error_occurred = false;
> >>         jsestate->escontext.error_occurred = false;
>
> > Good catch.  It was introduced by this commit 231b7d670b21.
> > Add Amit to the cc list.
>
> Nice catch!  The two duplicate statements were introduced in separate
> commits; looks like a copy-paste oversight in the later one.

Oops, you're right -- I must have copy-pasted without noticing the
duplicate. Thanks Jian for catching that.  Will fix.

-- 
Thanks, Amit Langote

  5. Re: duplicate line in ExecEvalJsonCoercionFinish

    Amit Langote <amitlangote09@gmail.com> — 2025-07-17T06:11:04Z

    On Thu, Jul 17, 2025 at 12:03 PM Amit Langote <amitlangote09@gmail.com> wrote:
> On Thu, Jul 17, 2025 at 10:01 AM Richard Guo <guofenglinux@gmail.com> wrote:
> > On Thu, Jul 17, 2025 at 9:52 AM Tender Wang <tndrwang@gmail.com> wrote:
> > > jian he <jian.universality@gmail.com> 于2025年7月17日周四 07:39写道：
> > >> ExecEvalJsonCoercionFinish duplicate line:
> > >>         jsestate->escontext.error_occurred = false;
> > >>         jsestate->escontext.error_occurred = false;
> >
> > > Good catch.  It was introduced by this commit 231b7d670b21.
> > > Add Amit to the cc list.
> >
> > Nice catch!  The two duplicate statements were introduced in separate
> > commits; looks like a copy-paste oversight in the later one.
>
> Oops, you're right -- I must have copy-pasted without noticing the
> duplicate. Thanks Jian for catching that.  Will fix.

Done.  Thanks all.

-- 
Thanks, Amit Langote