Re: pg_dumpall --roles-only interact with other options

jian he <jian.universality@gmail.com>

From: jian he <jian.universality@gmail.com>

To: Zsolt Parragi <zsolt.parragi@percona.com>

Cc: Nathan Bossart <nathandbossart@gmail.com>, wangpeng <215722532@qq.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>

Date: 2026-03-02T07:20:24Z

Lists: pgsql-hackers

Attachments

v7-0001-pg_dumpall-error-out-conflict-options.patch (text/x-patch) patch v7-0001

On Wed, Feb 25, 2026 at 4:09 AM Zsolt Parragi <zsolt.parragi@percona.com> wrote:
>
> Shouldn't these also use pg_log_error + pg_log_error_hint + exit_nicely?
>

Sure.

> Otherwise it looks good to me.
While rebasing, I found that I missed the combination: --statistics
and --no-statistics.
Since pg_dump will error out on this combination, pg_dumpall should too.



--
jian
https://www.enterprisedb.com/

Commits

pg_dumpall: Fix handling of conflicting options.
- b2898baaf7e4 19 (unreleased) landed
pg_dump: Add dumpSchema and dumpData derivative flags.
- 96a81c1be929 18.0 cited