Re: CREATE TABLE LIKE INCLUDING TRIGGERS

jian he <jian.universality@gmail.com>

From: jian he <jian.universality@gmail.com>

To: PostgreSQL-development <pgsql-hackers@postgresql.org>

Date: 2025-12-31T05:08:24Z

Lists: pgsql-hackers

Attachments

v4-0001-add-relOid-field-to-CreateTrigStmt.patch (text/x-patch)
v4-0002-add-constrrelOid-field-to-CreateTrigStmt.patch (text/x-patch)
v4-0003-CREATE-TABLE-LIKE-INCLUDING-TRIGGERS.patch (text/x-patch)

On Mon, Dec 29, 2025 at 9:26 AM jian he <jian.universality@gmail.com> wrote:
>
> v3-0001 and v3-0002 refactor the CreateTrigger function.
> The parameters relOid and refRelOid are removed and instead added to the
> CreateTrigStmt structure.
>
> These two patch (v3-0001, v3-0002) will also be used in [1]
> [1]: https://postgr.es/m/CACJufxGkqYrmwMdvUOUPet0443oUTgF_dKCpw3TfJiutfuywAQ@mail.gmail.com
>
> v3-0003 is for CREATE TABLE LIKE INCLUDING TRIGGERS.
>
hi.

https://cirrus-ci.com/build/6583555523870720
https://api.cirrus-ci.com/v1/artifact/task/5664491007901696/testrun/build/testrun/pg_upgrade/002_pg_upgrade/data/regression.diffs

only FreeBSD fails. I suspect this is because pstrdup was not used in
generateClonedTriggerStmt.

now using pstrdup in generateClonedTriggerStmt; otherwise v4-0003 is identical
to v3-0003.


--
jian
https://www.enterprisedb.com/