Re: Virtual generated columns
jian he <jian.universality@gmail.com>
Commits
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
Expand virtual generated columns for ALTER COLUMN TYPE
- 5069fef1cfae 18.0 landed
-
Eliminate code duplication in replace_rte_variables callbacks
- 363a6e8c6fcf 18.0 landed
-
Expand virtual generated columns in the planner
- 1e4351af329f 18.0 landed
-
Virtual generated columns
- 83ea6c54025b 18.0 landed
-
Additional tests for stored generated columns
- 41084409f635 18.0 landed
-
Improve generated_stored test
- 44b61efb7928 18.0 landed
- 86749ea3b766 18.0 landed
-
Fix handling of CREATE DOMAIN with GENERATED constraint syntax
- 84a67725cd11 18.0 landed
-
Add pg_constraint rows for not-null constraints
- 14e87ffa5c54 18.0 cited
-
Put generated_stored test objects in a schema
- 894be11adfa6 18.0 landed
-
Rename regress test generated to generated_stored
- b9ed4969250d 18.0 landed
-
Small code simplification
- 7ff9afbbd1df 18.0 landed
-
Remove useless code
- e26d313bad92 18.0 landed
-
Remove useless initializations
- da2aeba8f533 18.0 landed
-
doc: Clarify that pg_attrdef also stores generation expressions
- da486d360103 18.0 landed
-
Clean out column-level pg_init_privs entries when dropping tables.
- 76618097a6c0 17.0 cited
-
Re-implement the ereport() macro using __VA_ARGS__.
- e3a87b4991cc 13.0 cited
Attachments
- v10-0001-refactor-ExecGetExtraUpdatedCols.no-cfbot (application/octet-stream)
On Fri, Nov 29, 2024 at 6:13 PM Peter Eisentraut <peter@eisentraut.org> wrote: > > - Added support for virtual columns in trigger column lists. (For that, > I renamed ExecInitStoredGenerated() to ExecInitGenerated(), which > handles the computation of ri_extraUpdatedCols.) > why not duplicate some code from ExecInitStoredGenerated to ExecGetExtraUpdatedCols? * now the expression is that something initiated for the virtual generated column. which may not be necessary for virtual columns. let's make ResultRelInfo->ri_GeneratedExprsI, ResultRelInfo->ri_GeneratedExprsU be NULL for virtual columns. currently it may look like this: (gdb) p resultRelInfo->ri_GeneratedExprsU $20 = (ExprState **) 0x34f9638 (gdb) p resultRelInfo->ri_GeneratedExprsU[0] $21 = (ExprState *) 0x0 (gdb) p resultRelInfo->ri_GeneratedExprsU[1] $22 = (ExprState *) 0x0 (gdb) p resultRelInfo->ri_GeneratedExprsU[2] $23 = (ExprState *) 0x40 * ExecInitStoredGenerated main used in ExecComputeStoredGenerated. * we also need to slightly change ExecInitGenerated's comments. * in InitResultRelInfo, do we need explicit set ri_Generated_valid to false? * duplicate code won't have big performance issues, since build_column_default will take most of the time. the attached patch makes ExecInitStoredGenerated as is; duplicate some code from ExecInitStoredGenerated to ExecGetExtraUpdatedCols.