Re: typedef struct WindowClause misleading comments

jian he <jian.universality@gmail.com>

From: jian he <jian.universality@gmail.com>
To: David Rowley <dgrowleyml@gmail.com>
Cc: PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2026-06-09T06:11:57Z
Lists: pgsql-hackers
On Tue, Jun 9, 2026 at 10:15 AM David Rowley <dgrowleyml@gmail.com> wrote:
>
> On Tue, 9 Jun 2026 at 13:56, jian he <jian.universality@gmail.com> wrote:
> > Query jumbling considers the ORDER BY clause; therefore, the comment
> > below is inaccurate.
> >
> > /
> >  * The information relevant for the query jumbling is the partition clause
> >  * type and its bounds.
> >  */
>
> I think the comment should be deleted.  It's pretty obvious which
> fields are used by looking at the pg_node_attr(query_jumble_ignore)
> attributes.
>

I agree.
Let's delete it.



Commits

  1. Fix various query jumble comments