Re: Virtual generated columns

jian he <jian.universality@gmail.com>

From: jian he <jian.universality@gmail.com>

To: Peter Eisentraut <peter@eisentraut.org>

Cc: pgsql-hackers <pgsql-hackers@postgresql.org>, Dean Rasheed <dean.a.rasheed@gmail.com>

Date: 2024-09-03T04:59:37Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Expand virtual generated columns for ALTER COLUMN TYPE
- 5069fef1cfae 18.0 landed
Eliminate code duplication in replace_rte_variables callbacks
- 363a6e8c6fcf 18.0 landed
Expand virtual generated columns in the planner
- 1e4351af329f 18.0 landed
Virtual generated columns
- 83ea6c54025b 18.0 landed
Additional tests for stored generated columns
- 41084409f635 18.0 landed
Improve generated_stored test
- 44b61efb7928 18.0 landed
- 86749ea3b766 18.0 landed
Fix handling of CREATE DOMAIN with GENERATED constraint syntax
- 84a67725cd11 18.0 landed
Add pg_constraint rows for not-null constraints
- 14e87ffa5c54 18.0 cited
Put generated_stored test objects in a schema
- 894be11adfa6 18.0 landed
Rename regress test generated to generated_stored
- b9ed4969250d 18.0 landed
Small code simplification
- 7ff9afbbd1df 18.0 landed
Remove useless code
- e26d313bad92 18.0 landed
Remove useless initializations
- da2aeba8f533 18.0 landed
doc: Clarify that pg_attrdef also stores generation expressions
- da486d360103 18.0 landed
Clean out column-level pg_init_privs entries when dropping tables.
- 76618097a6c0 17.0 cited
Re-implement the ereport() macro using __VA_ARGS__.
- e3a87b4991cc 13.0 cited

Attachments

v5-0001-Virtual-generated-wholerow-var-and-virtual-che.no-cfbot (application/octet-stream)

On Thu, Aug 29, 2024 at 9:35 PM jian he <jian.universality@gmail.com> wrote:
>
> On Thu, Aug 29, 2024 at 8:15 PM Peter Eisentraut <peter@eisentraut.org> wrote:
> >

> >
> > The new patch does some rebasing and contains various fixes to the
> > issues you presented.  As I mentioned, I'll look into improving the
> > rewriting.
>
>
> based on your latest patch (v4-0001-Virtual-generated-columns.patch),
> I did some minor cosmetic code change
> and tried to address get_attgenerated overhead.
>
> basically in expand_generated_columns_in_query
> and expand_generated_columns_in_expr preliminary collect (reloid,attnum)
> that have generated_virtual flag into expand_generated_context.
> later in expand_generated_columns_mutator use the collected information.
>
> deal with wholerow within the expand_generated_columns_mutator seems
> tricky, will try later.

please just ignore v4-0001-Virtual-generated-columns_minorchange.no-cfbot,
which I made some mistakes, but the tests still passed.

please checking this mail attached
v5-0001-Virtual-generated-wholerow-var-and-virtual-che.no-cfbot

It solves:
1. minor cosmetic changes.
2. virtual generated column wholerow var reference, tests added.
3. optimize get_attgenerated overhead, instead of for each var call
get_attgenerated.
  walk through the query tree, collect the virtual column's relation
oid, and the virtual generated column's attnum
and use this information later.

I will check the view insert case later.