Re: Vacuum statistics

jian he <jian.universality@gmail.com>

From: jian he <jian.universality@gmail.com>

To: Alena Rybakina <a.rybakina@postgrespro.ru>

Cc: Ilia Evdokimov <ilya.evdokimov@tantorlabs.com>, Andrei Zubkov <zubkov@moonset.ru>, Alena Rybakina <lena.ribackina@yandex.ru>, pgsql-hackers <pgsql-hackers@postgresql.org>, a.lepikhov@postgrespro.ru

Date: 2024-08-22T02:47:00Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Move wal_buffers_full from PgStat_PendingWalStats to WalUsage
- eaf502747bac 18.0 cited

Attachments

v6-0002-minor-doc-change-to-make-build-successfuly.no-cfbot (application/octet-stream)
v6-0001-minor-refactor-pg_stats_vacuum-and-sub-routine.no-cfbot (application/octet-stream)
v6-0004-ensure-pg_stats_vacuum-object-is-either-relati.no-cfbot (application/octet-stream)
v6-0003-refactor-regression-test.no-cfbot (application/octet-stream)

On Wed, Aug 21, 2024 at 6:37 AM Alena Rybakina
<a.rybakina@postgrespro.ru> wrote:
>
> We check it there: "tabentry->vacuum_ext.type != type". Or were you talking about something else?
>
> On 19.08.2024 12:32, jian he wrote:
>
> in pg_stats_vacuum
>     if (type == PGSTAT_EXTVAC_INDEX || type == PGSTAT_EXTVAC_HEAP)
>     {
>         Oid                    relid = PG_GETARG_OID(1);
>
>         /* Load table statistics for specified database. */
>         if (OidIsValid(relid))
>         {
>             tabentry = fetch_dbstat_tabentry(dbid, relid);
>             if (tabentry == NULL || tabentry->vacuum_ext.type != type)
>                 /* Table don't exists or isn't an heap relation. */
>                 PG_RETURN_NULL();
>
>             tuplestore_put_for_relation(relid, rsinfo, tabentry);
>         }
>         else
>         {
>        }
>
>
> So for functions pg_stat_vacuum_indexes and pg_stat_vacuum_tables,
> it seems you didn't check "relid" 's relkind,
> you may need to use get_rel_relkind.
>
> --

hi.
I mentioned some points at [1],
Please check the attached patchset to address these issues.

there are four occurrences of "CurrentDatabaseId", i am still confused
with usage of CurrentDatabaseId.

also please don't  top-post, otherwise the archive, like [2] is not
easier to read for future readers.
generally you quote first, then reply.

[1] https://postgr.es/m/CACJufxHb_YGCp=pVH6DZcpk9yML+SueffPeaRbX2LzXZVahd_w@mail.gmail.com
[2] https://postgr.es/m/78394e29-a900-4af4-b5ce-d6eb2d263fad@postgrespro.ru