Re: Non-text mode for pg_dumpall

jian he <jian.universality@gmail.com>

From: jian he <jian.universality@gmail.com>

To: Mahendra Singh Thalor <mahi6run@gmail.com>

Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>, Guillaume Lelarge <guillaume@lelarge.info>, Nathan Bossart <nathandbossart@gmail.com>, Magnus Hagander <magnus@hagander.net>, Tom Lane <tgl@sss.pgh.pa.us>, Andrew Dunstan <andrew@dunslane.net>, PostgreSQL-development <pgsql-hackers@postgresql.org>, Dilip Kumar <dilipbalaut@gmail.com>

Date: 2025-01-11T15:59:37Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Add non-text output formats to pg_dumpall
- 763aaa06f034 19 (unreleased) landed
Improve pg_dump/pg_dumpall help synopses and terminology
- dec6643487bb 18.0 cited
Non text modes for pg_dumpall, correspondingly change pg_restore
- 1495eff7bdb0 18.0 landed
Doc: manually break lines in wide UUID examples.
- a6524105d20b 18.0 cited

hi.
the following two tests, you can add to src/bin/pg_dump/t/001_basic.pl

command_fails_like(
    [ 'pg_restore', '--globals-only', '-f', 'xxx' ],
    qr/\Qpg_restore: error: option -g\/--globals-only requires option
-d\/--dbname\E/,
    'pg_restore: error: option -g/--globals-only requires option -d/--dbname'
);
command_fails_like(
    [ 'pg_restore', '--globals-only', '--file=xxx', '--exclude-database=x',],
    qr/\Qpg_restore: error: option --exclude-database cannot be used
together with -g\/--globals-only\E/,
    'pg_restore: error: option --exclude-database cannot be used
together with -g/--globals-only'
);


in pg_restore.sgml.
     <varlistentry>
      <term><option>--exclude-database=<replaceable
class="parameter">pattern</replaceable></option></term>
      <listitem>
the position should right after
     <varlistentry>
      <term><option>-d <replaceable
class="parameter">dbname</replaceable></option></term>
      <term><option>--dbname=<replaceable
class="parameter">dbname</replaceable></option></term>


should
pg_restore --globals-only
pg_restore --exclude-database=pattern
be in a separate patch?


i am also wondering what will happen:
pg_restore --exclude-database=pattern --dbname=pattern