Horton

Re: pg_restore --no-policies should not restore policies' comment

jian he <jian.universality@gmail.com>

View thread View on postgr.es
From: jian he <jian.universality@gmail.com>
To: Fujii Masao <masao.fujii@gmail.com>
Cc: Fujii Masao <masao.fujii@oss.nttdata.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2025-08-27T06:17:41Z
Lists: pgsql-hackers 
On Tue, Aug 26, 2025 at 7:43 PM Fujii Masao <masao.fujii@gmail.com> wrote:
>
> >
> > summary of attached patch:
>
> Thanks for the patches!
>
> > 01: make pg_restore not restore comments if comments associated
> > objects are excluded.
>
> > TODO: need perl tests
>
> How about adding tests for pg_restore --no-policies in 002_pg_dump.pl,
> as in the attached patch?
>

it works fine on my local linux machine.

> Since --no-publications and --no-subscriptions have been around for a long time,
> while --no-policies was added in v18, I wonder if it makes sense to first fix
> the publications and subscriptions cases (and add tests for them) and back-patch
> to all supported versions. Then we can handle the policies case and
> back-patch it
> only to v18. Does that sound reasonable?
>
works for me.

Commits

  1. pg_dump: Remove unnecessary code for security labels on extensions.

  2. pg_restore: Fix security label handling with --no-publications/subscriptions.

  3. pg_dump: Fix dumping of security labels on subscriptions and event triggers.

  4. pg_restore: Fix comment handling with --no-policies.

  5. pg_restore: Fix comment handling with --no-publications / --no-subscriptions.

  6. Core support for "extensions", which are packages of SQL objects.