Horton
Menu

Re: ALTER DOMAIN ADD NOT NULL NOT VALID

jian he <jian.universality@gmail.com>

View thread
From: jian he <jian.universality@gmail.com>
To: Quan Zongliang <quanzongliang@yeah.net>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2025-05-28T07:38:51Z
Lists: pgsql-hackers

Attachments

On Thu, May 22, 2025 at 10:08 PM Quan Zongliang <quanzongliang@yeah.net> wrote:
>
> It makes sense to support the "NOT NULL NOT VALID" option.
>
> The two if statements in the AlterDomainNotNull() should be adjusted.
>
> if (typTup->typnotnull == notNull && !notNull)
> ==>
> if (!notNull && !typTup->typnotnull)
>
>
> if (typTup->typnotnull == notNull && notNull)
> ==>
> if (notNull && typTup->typnotnull)
>

yech, you are right.

There is one failed test [0] because of query result order,
so I add "ORDER BY conname COLLATE "C";"  to stabilize tests.

[0] https://api.cirrus-ci.com/v1/artifact/task/6676676240736256/testrun/build/testrun/pg_upgrade/002_pg_upgrade/data/regression.diffs

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. Reduce lock level for ALTER DOMAIN ... VALIDATE CONSTRAINT