Re: PATCH: jsonpath string methods: lower, upper, initcap, l/r/btrim, replace, split_part

jian he <jian.universality@gmail.com>

From: jian he <jian.universality@gmail.com>

To: "David E. Wheeler" <david@justatheory.com>

Cc: Chao Li <li.evan.chao@gmail.com>, Álvaro Herrera <alvherre@kurilemu.de>, Florents Tselai <florents.tselai@gmail.com>, Tom Lane <tgl@sss.pgh.pa.us>, Peter Eisentraut <peter@eisentraut.org>, Robert Haas <robertmhaas@gmail.com>, Alexander Korotkov <aekorotkov@gmail.com>, pgsql-hackers <pgsql-hackers@lists.postgresql.org>, Andrew Dunstan <andrew@dunslane.net>

Date: 2025-11-28T10:29:17Z

Lists: pgsql-hackers

On Wed, Oct 29, 2025 at 3:39 AM David E. Wheeler <david@justatheory.com> wrote:
>

> Updated patches attached.
>
> Best,
>
> David
>
hi.

/*
 * All node's type of jsonpath expression
 *
 * These become part of the on-disk representation of the jsonpath type.
 * Therefore, to preserve pg_upgradability, the order must not be changed, and
 * new values must be added at the end.
 *
 * It is recommended that switch cases etc. in other parts of the code also
 * use this order, to maintain some consistency.
 */
typedef enum JsonPathItemType

some "switch" in the attached patch does not preserve the JsonPathItemType order
consistency, like executeItemOptUnwrapTarget.

--
jian
https://www.enterprisedb.com/

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Add additional jsonpath string methods
- bd4f879a9cdd 19 (unreleased) landed
Rename jsonpath method arg tokens
- a35c9d524ed0 19 (unreleased) landed
Fix transient memory leakage in jsonpath evaluation.
- 5a2043bf7131 19 (unreleased) cited
Make jsonpath .string() be immutable for datetimes.
- cb599b9ddfcc 18.0 cited