Horton

Re: pg_dumpall --roles-only interact with other options

jian he <jian.universality@gmail.com>

View thread View on postgr.es
From: jian he <jian.universality@gmail.com>
To: Nathan Bossart <nathandbossart@gmail.com>
Cc: Zsolt Parragi <zsolt.parragi@percona.com>, wangpeng <215722532@qq.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2026-03-03T01:48:18Z
Lists: pgsql-hackers 
On Tue, Mar 3, 2026 at 6:41 AM Nathan Bossart <nathandbossart@gmail.com> wrote:
>
> I'm not thrilled about the long list of checks.  What if we added a
> function that could check an arbitrary number of mutually exclusive
> options, a bit like the attached?
>
hi.

This is neater than my version, and overall it looks good to me.
Once this is committed, we can use CheckMutuallyExclusiveOpts in both
pg_dump.c and pg_restore.c.



--
jian
https://www.enterprisedb.com/

Commits

  1. pg_dumpall: Fix handling of conflicting options.

  2. pg_dump: Add dumpSchema and dumpData derivative flags.