Re: not null constraints, again

in ATExecSetNotNull
        /*
         * If we find an appropriate constraint, we're almost done, but just
         * need to change some properties on it: if we're recursing, increment
         * coninhcount; if not, set conislocal if not already set.
         */
        if (recursing)
        {
            conForm->coninhcount++;
            changed = true;
        }
        else if (!conForm->conislocal)
        {
            conForm->conislocal = true;
            changed = true;
            elog(INFO, "constraint islocal attribute changed");
        }
        if (recursing && !conForm->conislocal)
            elog(INFO, "should not happenX");


"should not happenX" appeared in regression.diff, but not
"constraint islocal attribute changed"
Does that mean the IF, ELSE IF logic is not right?




in doc/src/sgml/ref/create_table.sgml
[ NO INHERIT ]
can apply to
<replaceable class="parameter">table_constraint</replaceable>
and
<replaceable class="parameter">column_constraint</replaceable>
so we should change create_table.sgml
accordingly?