Re: Refactoring: Use soft error reporting for *_opt_error functions

jian he <jian.universality@gmail.com>

From: jian he <jian.universality@gmail.com>

To: Michael Paquier <michael@paquier.xyz>

Cc: Dean Rasheed <dean.a.rasheed@gmail.com>, Amul Sul <sulamul@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>

Date: 2025-10-05T22:19:49Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Fix two comments in numeric.c
- 0c7f10302820 19 (unreleased) landed
Switch some numeric-related functions to use soft error reporting
- 4246a977bad6 19 (unreleased) landed
Change pg_lsn_in_internal() to use soft error reporting
- ae453120085f 19 (unreleased) landed

On Fri, Sep 5, 2025 at 12:58 PM Michael Paquier <michael@paquier.xyz> wrote:
>
> Applied after a few tweaks, including changes to the comments, the
> suggestion of "division_by_zero" for the goto labels, and splitting
> the patch into two parts for pg_lsn and numeric.

/*
 * Internal version of int8_numeric() with support for soft error reporting.
 */
int64
numeric_int8_safe(Numeric num, Node *escontext)

the above comment "int8_numeric" should be "numeric_int8"?