Horton

Re: pg_restore --no-policies should not restore policies' comment

jian he <jian.universality@gmail.com>

View thread View on postgr.es
From: jian he <jian.universality@gmail.com>
To: Fujii Masao <masao.fujii@gmail.com>
Cc: Fujii Masao <masao.fujii@oss.nttdata.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2025-10-16T14:22:52Z
Lists: pgsql-hackers 
On Thu, Sep 18, 2025 at 11:03 AM Fujii Masao <masao.fujii@gmail.com> wrote:
>
> On Tue, Sep 16, 2025 at 5:04 PM Fujii Masao <masao.fujii@gmail.com> wrote:
> >
> > On Tue, Sep 9, 2025 at 4:56 PM Fujii Masao <masao.fujii@gmail.com> wrote:
> > > Thanks for the review! Unless there are any objections,
> > > I’ll run the tests again and then push the patches.
> >
> > I've pushed patches 0001, 0002, and 0003. I'll push 0004 later.
>
> I've pushed 0004, thanks!
>
> > Buildfarm member petalura reported a failure at [1] after 0001 was backpatched
> > to v13. However, the server logs show a "double free or corruption" error
> > occurring as the backend was exiting. Since that code was not touched by 0001,
> > for now I don't think this failure is related to the patch...
> > But am I missing something?
>
> After pushing 0004, petalura reported another failure with a "double
> free or corruption" error:
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=petalura&dt=2025-09-18%2002%3A14%3A32
>
> Buildfarm member phycodurus also reported similar failures:
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=phycodurus&dt=2025-09-16%2011%3A09%3A07
> https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=phycodurus&dt=2025-09-16%2016%3A44%3A37
>
> I'll dig deeper into this issue.
>

It appears that this issue no longer exists, per https://bfbot.cputube.org

> As for the unnecessary code for security labels on extensions
> you mentioned earlier, I've created a patch to remove it. Patch attached.

looks good to me.

Commits

  1. pg_dump: Remove unnecessary code for security labels on extensions.

  2. pg_restore: Fix security label handling with --no-publications/subscriptions.

  3. pg_dump: Fix dumping of security labels on subscriptions and event triggers.

  4. pg_restore: Fix comment handling with --no-policies.

  5. pg_restore: Fix comment handling with --no-publications / --no-subscriptions.

  6. Core support for "extensions", which are packages of SQL objects.