Horton
Menu

Re: Doc Rework: Section 9.16.13 SQL/JSON Query Functions

jian he <jian.universality@gmail.com>

View thread
From: jian he <jian.universality@gmail.com>
To: Amit Langote <amitlangote09@gmail.com>
Cc: "David G. Johnston" <david.g.johnston@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2024-07-09T01:38:53Z
Lists: pgsql-hackers 
On Mon, Jul 8, 2024 at 8:57 PM Amit Langote <amitlangote09@gmail.com> wrote:
>
> Updated patch attached.
>

         Returns true if the SQL/JSON <replaceable>path_expression</replaceable>
-        applied to the <replaceable>context_item</replaceable> using the
-        <literal>PASSING</literal> <replaceable>value</replaceable>s yields any
-        items.
+        applied to the <replaceable>context_item</replaceable> doesn't yield
+        any items.
should "doesn't" be removed?
should it be "yields"?


+        set. The <literal>ON ERROR</literal> clause specifies the behavior
+        if an error occurs when evaluating
<replaceable>path_expression</replaceable>,
+        when coercing the result value to the
<literal>RETURNING</literal> type,
+        or when evaluating the <literal>ON EMPTY</literal> expression if the
+        <replaceable>path_expression</replaceable> evaluation results in an
+        empty set.
last sentence, "in an empty set." should be "is an empty set"


Other than that, it looks good to me.

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. SQL/JSON: Various improvements to SQL/JSON query function docs