Horton

Re: CREATE SCHEMA ... CREATE DOMAIN support

jian he <jian.universality@gmail.com>

View thread View on postgr.es
From: jian he <jian.universality@gmail.com>
To: Kirill Reshke <reshkekirill@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2024-11-27T03:42:12Z
Lists: pgsql-hackers

Attachments

On Sat, Nov 23, 2024 at 1:19 PM jian he <jian.universality@gmail.com> wrote:
>
> I didn't add a doc entry. I will do it later.
hi
attached patch with thorough tests and documentation.

one issue i still have is:
CREATE SCHEMA regress_schema_2 AUTHORIZATION CURRENT_ROLE
  create domain ss1 as ss
  create domain ss as text;
ERROR:  type "ss" does not exist

the error message seems not that OK,
if we can point out the error position, that would be great.
like what we did with create schema create table:

CREATE SCHEMA regress_schema_2 AUTHORIZATION CURRENT_ROLE
    create table t(a int, b x);
ERROR:  type "x" does not exist
LINE 2:     create table t(a int, b x);
                                    ^

Commits

  1. Don't try to re-order the subcommands of CREATE SCHEMA.

  2. Execute foreign key constraints in CREATE SCHEMA at the end.

  3. Support more object types within CREATE SCHEMA.