Horton

Re: pg_dumpall --roles-only interact with other options

jian he <jian.universality@gmail.com>

View thread View on postgr.es
From: jian he <jian.universality@gmail.com>
To: Zsolt Parragi <zsolt.parragi@percona.com>
Cc: Nathan Bossart <nathandbossart@gmail.com>, wangpeng <215722532@qq.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2026-02-09T06:31:22Z
Lists: pgsql-hackers

Attachments

On Fri, Feb 6, 2026 at 5:36 PM Zsolt Parragi <zsolt.parragi@percona.com> wrote:
>
> Please see the attached tap test case. It works with the current
> master branch, and fails with the patch. Basically my expectation is
> that if we use dumpall --schema-only, we should be able to restore it
> without errors, except for one error for the already existing
> postgres/current user which it ignores.
>
> I also found one more issue/behavior change: --no-schema --clean now
> generates DROP statements (roles, tablespaces, databases), while
> previously it didn't.

hi.

It would be better to simply reject the CONFLICT ONLY option and keep the rest
of the logic same as the HEAD. That way, we avoid any surprising behavior.
IMHO.

Please check attached v5.


--
jian
https://www.enterprisedb.com/

Commits

  1. pg_dumpall: Fix handling of conflicting options.

  2. pg_dump: Add dumpSchema and dumpData derivative flags.