Re: Fix tab completion in v18 for ALTER DATABASE/USER/ROLE ... RESET

jian he <jian.universality@gmail.com>

From: jian he <jian.universality@gmail.com>

To: Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>

Cc: pgsql-hackers@lists.postgresql.org

Date: 2025-07-22T10:28:18Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Fix tab completion for ALTER ROLE|USER ... RESET
- 88914332eaed 18.0 landed
- ca09ef3a6aa6 19 (unreleased) landed
Schema-qualify unnest() in ALTER DATABASE ... RESET
- 72c437f6e464 18.0 landed
- dbf5a83d4650 19 (unreleased) landed

On Thu, Jul 17, 2025 at 1:41 AM Dagfinn Ilmari Mannsåker
<ilmari@ilmari.org> wrote:
>
> Hi hackers,
>
> These two patches are split out from my earlier thread about improving
> tab completion for varous RESET forms
> (https://postgr.es/m/87bjqwwtic.fsf@wibble.ilmari.org), so that the bug
> fixes can be tracked as an open item for v18.
>
> Commits 9df8727c5067 and c407d5426b87 added tab completion for ALTER
> DATABASE ... RESET and ALTER ROLE/USER ... RESET, respectively, but
> they're both differently buggy.  The query for the DATABASE form
> neglected to schema-qualify the unnest() call, and the query for the
> ROLE/USER form shows all possible variables once you start typing a
> variable name, not just the ones that are set on the role.  The attached
> patches fix both.
>

I played around with it, and overall it looks good.