Horton

Re: Set query_id for query contained in utility statement

jian he <jian.universality@gmail.com>

View thread View on postgr.es
From: jian he <jian.universality@gmail.com>
To: Anthonin Bonnefoy <anthonin.bonnefoy@datadoghq.com>
Cc: Michael Paquier <michael@paquier.xyz>, PostgreSQL Hackers <pgsql-hackers@postgresql.org>
Date: 2024-10-15T13:22:53Z
Lists: pgsql-hackers 
hi.

explain(verbose) SELECT 1, 2, 3\;              explain SELECT 1, 2, 3, 4;
will transformed to
explain(verbose) SELECT 1, 2, 3;              explain SELECT 1, 2, 3, 4;

it seems to me your patch care about following position.
explain(verbose) SELECT 1, 2, 3;              explain SELECT 1, 2, 3, 4;
                                                      ^


but this patch [1] at another thread will get the top level statement
(passed the raw parse, no syntax error) beginning more effortless.
explain(verbose) SELECT 1, 2, 3;              explain SELECT 1, 2, 3, 4;
^                                                                  ^

can you try to looking at [1]. it may help to resolve this patch problem.


[1] https://www.postgresql.org/message-id/2245576.1728418678%40sss.pgh.pa.us

Commits

  1. Set query ID for inner queries of CREATE TABLE AS and DECLARE

  2. Track more precisely query locations for nested statements

  3. pg_stat_statements: Add tests for nested queries with level tracking

  4. Fix race condition in COMMIT PREPARED causing orphaned 2PC files