Re: Report planning memory in EXPLAIN ANALYZE
jian he <jian.universality@gmail.com>
From: jian he <jian.universality@gmail.com>
To: Ashutosh Bapat <ashutosh.bapat.oss@gmail.com>
Cc: Andrei Lepikhov <a.lepikhov@postgrespro.ru>,
Alvaro Herrera <alvherre@alvh.no-ip.org>, Andy Fan <zhihui.fan1213@gmail.com>, David Rowley <dgrowleyml@gmail.com>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2023-12-11T08:36:11Z
Lists: pgsql-hackers
On Mon, Dec 4, 2023 at 3:24 PM Ashutosh Bapat <ashutosh.bapat.oss@gmail.com> wrote: > > On Fri, Dec 1, 2023 at 8:27 AM Andrei Lepikhov > <a.lepikhov@postgrespro.ru> wrote: > > > > On 30/11/2023 18:40, Alvaro Herrera wrote: > > > Well, SUMMARY is enabled by default with ANALYZE, and I'd rather not > > > have planner memory consumption displayed by default with all EXPLAIN > > > ANALYZEs. So yeah, I still think this deserves its own option. > > > > > > But let's hear others' opinions on this point. I'm only one vote here. > > > > I agree; it should be disabled by default. The fact that memory > > consumption outputs with byte precision (very uncomfortable for > > perception) is a sign that the primary audience is developers and for > > debugging purposes. > > That's 2 vs 1. Here's patch with MEMORY option added. Replying to > Alvaro's earlier relevant comments. > "Include information on planner's memory consumption. Specially, include the total memory allocated by the planner and net memory that remains used at the end of the planning. It defaults to <literal>FALSE</literal>. " doc/src/sgml/ref/explain.sgml I can view MemoryContextSizeDifference, figure out the meaning. But I am not sure "net memory that remains used at the end of the planning" is the correct description. (I am not native english speaker).
Commits
-
Add EXPLAIN (MEMORY) to report planner memory consumption
- 5de890e3610d 17.0 landed
-
Fix explain regression test failure.
- eabba4a3eb71 14.0 cited