Horton

Re: IGNORE/RESPECT NULLS can be specified for (prokind == 'f').

jian he <jian.universality@gmail.com>

View thread View on postgr.es
From: jian he <jian.universality@gmail.com>
To: Tatsuo Ishii <ishii@postgresql.org>
Cc: pgsql-hackers@postgresql.org
Date: 2026-06-17T00:34:22Z
Lists: pgsql-hackers 
On Wed, Jun 17, 2026 at 7:47 AM Tatsuo Ishii <ishii@postgresql.org> wrote:
>

> > To fix this, ParseFuncOrColumn() now checks whether other than window
> > functions are used with the null treatment clause. If so, error out.
> >
> > Also remove the unnecessary test for "aggregate functions do not
> > accept RESPECT/IGNORE NULLS" because it is now checked in the
> > early-stage new check. The window regression test expected file is
> > changed accordingly.
>
> I'm going to push the patch today if there's no objection.

The code looks good to me, and the commit message is clear and well-written.

Commits

  1. Remove stray blank line in ParseFuncOrColumn()

  2. Refine error reporting for null treatment on non-window functions

  3. Fix error message typo.

  4. Fix to not allow null treatment to non window functions.

  5. Add IGNORE NULLS/RESPECT NULLS option to Window functions.