Re: Cleaning up array_in()

jian he <jian.universality@gmail.com>

From: jian he <jian.universality@gmail.com>

To: Alexander Lakhin <exclusion@gmail.com>

Cc: Heikki Linnakangas <hlinnaka@iki.fi>, Tom Lane <tgl@sss.pgh.pa.us>, Nikhil Benesch <nikhil.benesch@gmail.com>, Nathan Bossart <nathandbossart@gmail.com>, pgsql-hackers@lists.postgresql.org

Date: 2023-09-11T05:26:16Z

Lists: pgsql-hackers

Attachments

v6-0001-Simplify-and-speed-up-ReadArrayStr.patch (application/x-patch) patch v6-0001
v6-0002-Rewrite-ArrayCount-to-make-dimensionality-checks-.patch (application/x-patch) patch v6-0002
v6-0004-Extract-loop-to-read-array-dimensions-to-subrouti.patch (application/x-patch) patch v6-0004
v6-0003-Re-indent-ArrayCount.patch (application/x-patch) patch v6-0003
v6-0005-Determine-array-dimensions-and-parse-the-elements.patch (application/x-patch) patch v6-0005
v6-0006-refactor-ReadDimensionInt.patch (application/x-patch) patch v6-0006
v6-0007-refactor-ReadArrayStr.patch (application/x-patch) patch v6-0007

On Sun, Sep 10, 2023 at 6:00 PM Alexander Lakhin <exclusion@gmail.com> wrote:
> Case 1:
> SELECT '{1,'::integer[];
> ERROR:  malformed array literal: "{1,"
> LINE 1: SELECT '{1,'::integer[];
>                 ^
> DETAIL:  Unexpected end of input.
>
> vs
>
> ERROR:  malformed array literal: "{1,"
> LINE 1: SELECT '{1,'::integer[];
>                 ^
>
> (no DETAIL)
>
> Case 2:
> SELECT '{{},}'::text[];
> ERROR:  malformed array literal: "{{},}"
> LINE 1: SELECT '{{},}'::text[];
>                 ^
> DETAIL:  Unexpected "}" character
>
> vs
>   text
> ------
>   {}
> (1 row)
>
> Case 3:
> select '{\{}'::text[];
>   text
> -------
>   {"{"}
> (1 row)
>
> vs
>   text
> ------
>   {""}
>
> Best regards,
> Alexander

hi.
Thanks for reviewing it.

> DETAIL:  Unexpected end of input.
In many cases, ending errors will happen, so I consolidate it.

SELECT '{{},}'::text[];
solved by tracking current token type and previous token type.

select '{\{}'::text[];
solved by update dstendptr.

attached.

Commits

Don't specify number of dimensions in cases where we don't know it.
- 8d5573b92e66 17.0 landed
Improve readability and error detection of array_in().
- 83472de606db 17.0 landed
Add trailing commas to enum definitions
- 611806cd726f 17.0 cited