Horton

Re: Should we remove -Wdeclaration-after-statement?

jian he <jian.universality@gmail.com>

View thread
From: jian he <jian.universality@gmail.com>
To: Jelte Fennema-Nio <postgres@jeltef.nl>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Andres Freund <andres@anarazel.de>, Robert Haas <robertmhaas@gmail.com>, Andrew Dunstan <andrew@dunslane.net>, "ranier.vf@gmail.com" <ranier.vf@gmail.com>, chap@anastigmatix.net
Date: 2024-02-04T00:00:00Z
Lists: pgsql-hackers 
On Mon, Jan 29, 2024 at 11:04 PM Jelte Fennema-Nio <postgres@jeltef.nl> wrote:
>
> I feel like this is the type of change where there's not much
> discussion to be had. And the only way to resolve it is to use some
> voting to gauge community opinion.
>
> So my suggestion is for people to respond with -1, -0.5, +-0, +0.5, or
> +1 to indicate support against/for the change.
>
> I'll start: +1
>
> Attached is a patch that removes -Wdeclaration-after-statement in the
> codebase. This is mainly to be able to add it to the commitfest, to
> hopefully get a decent amount of responses.


I am new to c.
gcc has many options (https://man7.org/linux/man-pages/man1/gcc.1.html)
IIUC, postgres have some required CFLAGS,
While doing the test (http://cfbot.cputube.org/next.html), we also
have some CFLAGS
I am not sure they are the same.

if we can list these CFLAGS information in the
https://wiki.postgresql.org/wiki/So,_you_want_to_be_a_developer%3F
would be helpful.

But not voting because I am not sure of the implication.