Horton
Menu

Re: [PATCH] Remove dead code in ExecForPortionOfLeftovers()

jian he <jian.universality@gmail.com>

View thread
From: jian he <jian.universality@gmail.com>
To: Quan Zongliang <quanzongliang@yeah.net>
Cc: Aleksander Alekseev <aleksander@tigerdata.com>, PostgreSQL Development <pgsql-hackers@postgresql.org>
Date: 2026-04-22T04:24:08Z
Lists: pgsql-hackers 
On Wed, Apr 22, 2026 at 11:58 AM Quan Zongliang <quanzongliang@yeah.net> wrote:
>
>
> On 4/21/26 8:22 PM, Aleksander Alekseev wrote:
> > Hi,
> >
> > While reading 8e72d914c528 I noticed that
> > ForPortionOfState.fp_leftoverstypcache is not used for anything. I
> > suggest removing it, as attached.
> >
>
> Agree.
> It indeed did not make any reference anywhere.
>

I raised this issue at [1].
But apparently, it's actually being used for fixing a bug at [2].

[1]: https://www.postgresql.org/message-id/CACJufxHYntqy2fo9CFWDDrqKjcMK8DGRM3kse4YnXYnPYq2Hiw%40mail.gmail.com
[2]: https://www.postgresql.org/message-id/CA%2BrenyU5%3Dmihx6O8%2BERBmarZcuV1QiWB3X5bZhdptWoRM9G-Aw%40mail.gmail.com