Horton

Re: XID formatting and SLRU refactorings (was: Add 64-bit XIDs into PostgreSQL 15)

Maxim Orlov <orlovmg@gmail.com>

View thread View on postgr.es
From: Maxim Orlov <orlovmg@gmail.com>
To: Pavel Borisov <pashkin.elfe@gmail.com>
Cc: Japin Li <japinli@hotmail.com>, Alexander Korotkov <aekorotkov@gmail.com>, Peter Eisentraut <peter.eisentraut@enterprisedb.com>, Aleksander Alekseev <aleksander@timescale.com>, Kyotaro Horiguchi <horikyota.ntt@gmail.com>, Ilya Anfimov <ilan@tzirechnoy.com>, Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2022-03-17T16:25:00Z
Lists: pgsql-hackers

Attachments

Hi!

Here is the v20 patch. 0001 and 0002 are proposed into PG15 as
discussed above.
The whole set of patches is added into [1] to be committed into PG16.

In this version we've made a major revision related to printf/elog format
compatible with localization
as was proposed above.

We also think of adding 0003 patch related to 64 bit GUC's into this
thread. Suppose it also may be delivered
into PG15.

Aleksander Alekseev, we've done this major revision mentioned above and you
are free to continue working on this patch set.

Reviews and proposals are very welcome!

[1]
https://www.postgresql.org/message-id/flat/CACG%3DezZe1NQSCnfHOr78AtAZxJZeCvxrts0ygrxYwe%3DpyyjVWA%40mail.gmail.com

-- 
Best regards,
Maxim Orlov.

Commits

  1. Fix more holes with SLRU code in need of int64 for segment numbers

  2. Use more consistently int64 for page numbers in SLRU-related code

  3. Improve comments in slru.{c,h} about segment name format

  4. Reorder actions in ProcArrayApplyRecoveryInfo()

  5. Fix typo in 5a1dfde8334b

  6. Fix warning due non-standard inline declaration in 4ed8f0913bfdb5f355

  7. Add SLRU tests for 64-bit page case

  8. Make use FullTransactionId in 2PC filenames

  9. Use larger segment file names for pg_notify

  10. Index SLRUs by 64-bit integers rather than by 32-bit integers

  11. Keep track of transaction commit timestamps

  12. Handle 5-char filenames in SlruScanDirectory