Re: Custom tuplesorts for extensions

Maxim Orlov <orlovmg@gmail.com>

View thread View on postgr.es

From: Maxim Orlov <orlovmg@gmail.com>

To: Pavel Borisov <pashkin.elfe@gmail.com>

Cc: Alexander Korotkov <aekorotkov@gmail.com>, pgsql-hackers <pgsql-hackers@postgresql.org>

Date: 2022-06-23T12:12:27Z

Lists: pgsql-hackers

Attachments

v2-0005-Reorganize-data-structures.patch (text/x-patch) patch v2-0005
v2-0004-Move-freeing-memory-away-from-writetup.patch (text/x-patch) patch v2-0004
v2-0006-Split-tuplesortops.c.patch (text/x-patch) patch v2-0006
v2-0002-Tuplesortstate.getdatum1-method.patch (text/x-patch) patch v2-0002
v2-0001-Remove-Tuplesortstate.copytup.patch (text/x-patch) patch v2-0001
v2-0003-Put-abbreviation-logic-into-puttuple_common.patch (text/x-patch) patch v2-0003

Hi!

I've reviewed the patchset and noticed some minor issues:
- extra semicolon in macro (lead to warnings)
- comparison of var isWorker should be done in different way

Here is an upgraded version of the patchset.

Overall, I consider this patchset useful. Any opinions?

-- 
Best regards,
Maxim Orlov.

Commits

Split tuplesortvariants.c from tuplesort.c
- d0b193c0fad1 16.0 landed
Split TuplesortPublic from Tuplesortstate
- ec92fe98356a 16.0 landed
Move memory management away from writetup() and tuplesort_put*()
- 097366c45f5d 16.0 landed
Put abbreviation logic into puttuple_common()
- 033dd02db224 16.0 landed
Add new Tuplesortstate.removeabbrev function
- cadfdd1edff1 16.0 landed
Remove Tuplesortstate.copytup function
- d47da3162b4d 16.0 landed