Re: Spinlock can be released twice in procsignal.c

Maxim Orlov <orlovmg@gmail.com>

From: Maxim Orlov <orlovmg@gmail.com>

To: Andrey Borodin <x4mmm@yandex-team.ru>

Cc: Michael Paquier <michael@paquier.xyz>, "Maksim.Melnikov" <m.melnikov@postgrespro.ru>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Heikki Linnakangas <hlinnaka@iki.fi>, Jelte Fennema-Nio <postgres@jeltef.nl>

Date: 2025-02-26T09:33:16Z

Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

Fix possible double-release of spinlock in procsignal.c
- 62ec3e1f6786 18.0 landed

Attachments

v3-0001-Avoid-double-spinlock-release.patch (application/octet-stream) patch v3-0001

On Wed, 26 Feb 2025 at 11:26, Andrey Borodin <x4mmm@yandex-team.ru> wrote:

>
> I’d suggest to give some more descriptive name to “logit” and expand
> comment “/* sanity check */“. This comment was easier to understand when
> elog() was near, but now IMO we can have few words about what is going on.

Done. Except for a new name for "logit" variable. Unfortunately, I can't
think of anything sane. As an example I looked at sequence.c. The same name
is used there. I will gladly change this name to whatever you want if it
still look misleading or incomplete for you in some way or another. Just
write the name that you think is correct.

-- 
Best regards,
Maxim Orlov.