Horton

Re: Unit tests for SLRU

Maxim Orlov <orlovmg@gmail.com>

View thread View on postgr.es
From: Maxim Orlov <orlovmg@gmail.com>
To: Aleksander Alekseev <aleksander@timescale.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>, Peter Eisentraut <peter.eisentraut@enterprisedb.com>, Pavel Borisov <pashkin.elfe@gmail.com>, Noah Misch <noah@leadboat.com>, Daniel Gustafsson <daniel@yesql.se>
Date: 2022-04-05T11:22:22Z
Lists: pgsql-hackers 
>
> Again, I don't have a strong opinion here. If you insist, I will place the
> tests to regress.c.
>

It is up to committer to decide, but I think it would be good to place
tests in regression.
In my opinion, many things from core may be used by extensions. And then it
is up to extension authors to make relevant tests.

For me, it's enough to make a reasonable test coverage for SLRU without
investing too much effort into generalization.

-- 
Best regards,
Maxim Orlov.

Commits

  1. Add test module for SLRUs

  2. Fix comment of SimpleLruInit() in slru.c