Re: Patch for migration of the pg_commit_ts directory

Maxim Orlov <orlovmg@gmail.com>

From: Maxim Orlov <orlovmg@gmail.com>

To: Amit Kapila <amit.kapila16@gmail.com>

Cc: "Hayato Kuroda (Fujitsu)" <kuroda.hayato@fujitsu.com>, ls7777 <ls7777@yandex.ru>, "pgsql-hackers@postgresql.org" <pgsql-hackers@postgresql.org>

Date: 2025-10-06T07:58:55Z

Lists: pgsql-hackers

On Thu, 2 Oct 2025 at 11:49, Amit Kapila <amit.kapila16@gmail.com> wrote:

>  When we try to
> copy slots and the wal_level on the new server is minimal, we error
> out, so shouldn't we do the same here and error_out if
> track_commit_timestamp is not enabled and we have some valid commit_ts
> data to copy?
>

+1 Sounds reasonable to me. It's better to give an explicit error;
otherwise, we would remove data that the user clearly wants to migrate
to the new cluster. And deleting data just because the user forgot to
specify one parameter in a new cluster looks like a bad joke to me.

-- 
Best regards,
Maxim Orlov.

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →