Re: Test 041_checkpoint_at_promote.pl faild in installcheck due to missing injection_points
Maxim Orlov <orlovmg@gmail.com>
From: Maxim Orlov <orlovmg@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Tom Lane <tgl@sss.pgh.pa.us>, Alvaro Herrera <alvherre@alvh.no-ip.org>, pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2024-09-04T16:05:32Z
Lists: pgsql-hackers
On Wed, 4 Sept 2024 at 03:40, Michael Paquier <michael@paquier.xyz> wrote: > Any thoughts about the attached? This makes installcheck work here > with and without the configure switch. > > Works for me with configure build. Meson build, obviously, still need extra "meson compile install-test-files" step as expected. From your patch, I see that you used safe_psql call to check for availability of the injection_points extension. Are there some hidden, non-obvious reasons for it? It's much simpler to check output of the pg_config as Álvaro suggested above, does it? And we don't need active node for this. Or I miss something? And one other thing I must mention. I don't know why, but my pg_config from meson build show empty configure despite the fact, I make pass the same options in both cases. autotools: $ ./pg_config --configure '--enable-debug' '--enable-tap-tests' '--enable-depend' .... meson: $ ./pg_config --configure -- Best regards, Maxim Orlov.
Commits
-
Check availability of module injection_points in TAP tests
- 5735521ac2d5 18.0 landed
-
Avoid installcheck failure in TAP tests using injection_points
- bab1fd9277c2 17.0 landed
- 2cdcae9da696 18.0 landed
-
Simplify makefiles exporting twice enable_injection_points
- ff43b5e70d45 17.0 landed
- 516ff05539bb 18.0 landed