Re: POC: make mxidoff 64 bits
Maxim Orlov <orlovmg@gmail.com>
From: Maxim Orlov <orlovmg@gmail.com>
To: wenhui qiu <qiuwenhuifx@gmail.com>
Cc: Heikki Linnakangas <hlinnaka@iki.fi>,
Alexander Korotkov <aekorotkov@gmail.com>, Postgres hackers <pgsql-hackers@lists.postgresql.org>
Date: 2024-11-08T18:10:28Z
Lists: pgsql-hackers
Commits
Same data as JSON:
GET /api/v1/messages/:b64id/commits
the thread's linked commits as JSON, with link sources.
API reference →
-
Fix partial read handling in pg_upgrade's multixact conversion
- ac94ce8194e5 19 (unreleased) landed
-
Increase timeout in multixid_conversion upgrade test
- bd43940b02b2 19 (unreleased) landed
-
Improve sanity checks on multixid members length
- ecb553ae8211 19 (unreleased) landed
-
Clarify comment on multixid offset wraparound check
- 170361d7b869 14.21 landed
- b0b52b7123ae 15.16 landed
- 7d42e2367c6b 16.12 landed
- cd1a887fe9bf 17.8 landed
- 3fbad030a24d 18.2 landed
- 366dcdaf5779 19 (unreleased) landed
-
Never store 0 as the nextMXact
- 87a350e1f284 19 (unreleased) landed
-
Add runtime checks for bogus multixact offsets
- d4b7bde4183b 19 (unreleased) landed
-
Widen MultiXactOffset to 64 bits
- bd8d9c9bdfa0 19 (unreleased) landed
-
Move pg_multixact SLRU page format definitions to a separate header
- bb3b1c4f6462 19 (unreleased) landed
-
Convert confusing macros in multixact.c to static inline functions
- 0099b9408e8c 17.0 landed
-
Index SLRUs by 64-bit integers rather than by 32-bit integers
- 4ed8f0913bfd 17.0 cited
-
Cope with possible failure of the oldest MultiXact to exist.
- b6a3444fa635 9.4.4 cited
Attachments
- v6-0001-Use-64-bit-multixact-offsets.patch (application/octet-stream) patch v6-0001
- v6-0002-Make-pg_upgrade-convert-multixact-offsets.patch (application/octet-stream) patch v6-0002
- v6-0004-TEST-lower-SLRU_PAGES_PER_SEGMENT-set-bump-catver.patch (application/octet-stream) patch v6-0004
- v6-0005-TEST-initdb-option-to-initialize-cluster-with-non.patch (application/octet-stream) patch v6-0005
- v6-0003-Get-rid-of-MultiXactMemberFreezeThreshold-call.patch (application/octet-stream) patch v6-0003
- v6-0006-TEST-add-basic-mxidoff64-tests-005_mxidoff.pl.patch (application/octet-stream) patch v6-0006
- 0002-TEST-lower-SLRU_PAGES_PER_SEGMENT.patch (application/octet-stream) patch 0002
- 0001-Add-initdb-option-to-initialize-cluster-with-non-sta.patch (application/octet-stream) patch 0001
On Fri, 25 Oct 2024 at 06:39, wenhui qiu <qiuwenhuifx@gmail.com> wrote: > > + * Multixact members warning threshold. > + * > + * If difference bettween nextOffset and oldestOffset exceed this value, > we > + * trigger autovacuum in order to release the disk space if possible. > + */ > +#define MULTIXACT_MEMBER_AUTOVAC_THRESHOLD UINT64CONST(0xFFFFFFFF) > Can we refine this annotation a bit? for example > Thank you, fixed. Sorry for a late reply. There was a problem in upgrade with offset wraparound. Here is a fixed version. Test also added. I decide to use my old patch to set a non-standard multixacts for the old cluster, fill it with data and do pg_upgrade. Here is how to test. All the patches are for 14e87ffa5c543b5f3 master branch. 1) Get the 14e87ffa5c543b5f3 master branch apply patches 0001-Add-initdb-option-to-initialize-cluster-with-non-sta.patch and 0002-TEST-lower-SLRU_PAGES_PER_SEGMENT.patch 2) Get the 14e87ffa5c543b5f3 master branch in a separate directory and apply v6 patch set. 3) Build two branches. 4) Use ENV oldinstall to run the test: PROVE_TESTS=t/005_mxidoff.pl oldinstall=/home/orlov/proj/pgsql-new PG_TEST_NOCLEAN=1 make check -C src/bin/pg_upgrade/ Maybe, I'll make a shell script to automate this steps if required. -- Best regards, Maxim Orlov.