Horton

Re: postgres_fdw could deparse ArrayCoerceExpr

Maxim Orlov <orlovmg@gmail.com>

View thread View on postgr.es
From: Maxim Orlov <orlovmg@gmail.com>
To: Alexander Pyhalov <a.pyhalov@postgrespro.ru>
Cc: pgsql-hackers@lists.postgresql.org
Date: 2025-01-24T15:09:14Z
Lists: pgsql-hackers 
Look like an overlook for me. Apparently no one has encountered this use
case before.

Patch seems good to me with no visible defects. Deparse support was also
added. As well as a
test case. But do we really need copy/paste code for a T_ArrayCoerceExpr
case? To be more specific,
can we "reuse" T_RelabelType case, as it made for T_OpExpr and
T_DistinctExpr?

-- 
Best regards,
Maxim Orlov.

Commits

  1. Fix a typo in the deparseArrayCoerceExpr() header comment

  2. Support for deparsing of ArrayCoerceExpr node in contrib/postgres_fdw