Re: [PATCH] Skip unpublishable child tables when adding parent to publication

Arunprasad Rajkumar <ar.arunprasad@gmail.com>

From: Arunprasad Rajkumar <ar.arunprasad@gmail.com>
To: Euler Taveira <euler@eulerto.com>, Amit Kapila <amit.kapila16@gmail.com>, "Zhijie Hou (Fujitsu)" <houzj.fnst@fujitsu.com>
Cc: pgsql-hackers <pgsql-hackers@postgresql.org>
Date: 2025-12-18T17:15:37Z
Lists: pgsql-hackers
Hi Amit,

There seem to be different interpretations of your comment.

I understood it as suggesting that we should show a WARNING when adding a
partition or parent table that has unsupported descendant tables.

I would greatly appreciate some clarification on this point. Thanks a lot.

Regards,
Arun

On Wed, 17 Dec 2025 at 04:43, Euler Taveira <euler@eulerto.com> wrote:

> On Tue, Dec 16, 2025, at 6:34 AM, Amit Kapila wrote:
> >
> > Prohibiting all commands sounds too restrictive in all cases (FOR ALL
> > TABLES, FOR TABLE, etc.). It would be better if we can disallow
> > creating a publication when the user explicitly adds such a relation
> > in a FOR TABLE publication, otherwise raise a WARNING and don't make
> > it part of publication. The behavior should be the same for both
> > partition and inherited tables.
> >
>
> WFM. The attached patch checks the partitions too. The behavior is similar
> to
> inherited tables. However, I didn't understand the "otherwise" part. Are
> you
> suggesting to add WARNING in the FOR ALL TABLES and FOR TABLES IN SCHEMA if
> there is any unsupported relations?
>
>
> --
> Euler Taveira
> EDB   https://www.enterprisedb.com/