Re: BUG #18224: message bug in libpqwalreceiver.c.

Tomonari Katsumata <t.katsumata1122@gmail.com>

From: king tomo <t.katsumata1122@gmail.com>
To: t.katsumata1122@gmail.com, pgsql-bugs@lists.postgresql.org
Date: 2023-12-04T11:28:37Z
Lists: pgsql-bugs

Attachments

Hello

This is a simplest patch.
Please check it.

Best regards,
----
Tomonari Katsumata

2023年12月4日(月) 20:25 PG Bug reporting form <noreply@postgresql.org>:

> The following bug has been logged on the website:
>
> Bug reference:      18224
> Logged by:          Tomonari Katsumata
> Email address:      t.katsumata1122@gmail.com
> PostgreSQL version: 16.1
> Operating system:   any
> Description:
>
> Hello
>
> I found a small bug in the error message of libpqwalreceiver.c.
>
> According to the manual, identify_system returns one row and
> four columns. (This is also the actual behavior)
>
> https://www.postgresql.org/docs/current/protocol-replication.html#PROTOCOL-REPLICATION-IDENTIFY-SYSTEM
>
> However, when data other than one row and four columns is returned,
> incorrect values ​​are reported as expected values ​​as shown below.
>
> >Could not identify system: got X rows and Y fields, expected 3 rows and 1
> or more fields.
>
> It looks like the arguments are in the wrong order.
> Also, it seems that the decision to return 4 fields in 9.4 was not
> reflected.
>
> This is a trivial issue, but I was curious about it so I reported it.
>
> Best regards,
> ----
> Tomonari Katsumata
>
>

Commits

  1. Fix typo in comment