Horton

Re: Can we get rid of GetLocaleInfoEx() yet?

Juan José Santamaría Flecha <juanjo.santamaria@gmail.com>

View thread View on postgr.es
From: Juan José Santamaría Flecha <juanjo.santamaria@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2020-03-29T17:06:56Z
Lists: pgsql-hackers 
On Sun, Mar 29, 2020 at 7:00 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:

>
> In general, I think the problem is that we might be dealing with a
> Unix-style locale string, in which the encoding name might be quite
> a few other things besides "utf8".  But actually your patch works
> for that too, since what's going to happen next is we'll search the
> encoding_match_list[] for a match.  I do suggest being a bit more
> paranoid about what's a codepage number though, as attached.
> (Untested, since I lack a Windows environment, but it's pretty
> straightforward code.)
>

It works for the issue just fine, and more comments make a better a
patch, so no objections from me.

Regards,

Juan José Santamaría Flecha

Commits

  1. Be more careful about extracting encoding from locale strings on Windows.

  2. Support building with Visual Studio 2015