Re: Non-Active links being referred in our source code
Juan José Santamaría Flecha <juanjo.santamaria@gmail.com>
From: Juan José Santamaría Flecha <juanjo.santamaria@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: vignesh C <vignesh21@gmail.com>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2019-10-07T15:11:40Z
Lists: pgsql-hackers
Attachments
- 0001-Non-Active-links-in-win32_port.patch (application/octet-stream) patch 0001
On Sun, Oct 6, 2019 at 9:41 AM Michael Paquier <michael@paquier.xyz> wrote: > > On Sun, Oct 06, 2019 at 09:06:44AM +0530, vignesh C wrote: > > I could not find the equivalent links for the same. > > Should we update the links for the same? > > If it could be possible to find equivalent links which could update > to, it would be nice. About the broken links in win32_port.h, they are all referring to ntstatus. As for first case that shows the code groups, there is an up to date alternative. There is also an alternative for second case that points to their codes and descriptions. On the other hand, the last case is quoting a document that is no longer available, I would suggest to rephrase the comment, thus eliminating the quote. Please find attached a patch with the proposed alternatives. Regards, Juan José Santamaría Flecha
Commits
-
Refresh some incorrect links in pg_crc.c/h
- 1de4fd10922b 13.0 landed
-
Clarify some comments about ntstatus.h in win32_port.h
- 491bb81fb803 13.0 landed