Horton

Re: Postgres Windows build system doesn't work with python installed in Program Files

Juan José Santamaría Flecha <juanjo.santamaria@gmail.com>

View thread View on postgr.es
From: Juan José Santamaría Flecha <juanjo.santamaria@gmail.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Ranier Vilela <ranier.vf@gmail.com>, Victor Wagner <vitus@wagner.pp.ru>, PostgreSQL-development <pgsql-hackers@postgresql.org>
Date: 2020-05-05T22:17:03Z
Lists: pgsql-hackers 
On Tue, May 5, 2020 at 4:06 PM Michael Paquier <michael@paquier.xyz> wrote:

> On Mon, May 04, 2020 at 03:42:20PM +0200, Juan José Santamaría Flecha
> wrote:
> > +1, seems like the way to go to me.
>
> Attached is a patch for that and I have gone with a simple solution,
> with some bonus comments about the way things happen.
>

This solves the issue.

Please forgive me if I am being too nitpicky, but I find the comments a
little too verbose, a usage format might be more visual and easier to
explain:

Usage: build [[CONFIGURATION] COMPONENT]

The options are  case-insensitive.
CONFIGURATION sets the configuration to build, "debug" or "release" (by
default).
COMPONENT defines a component to build. An empty option means all
components.

Regards,

Juan José Santamaría Flecha

Commits

  1. Improve perl script in MSVC to build binaries

  2. Handle spaces for Python install location in MSVC scripts

  3. Use perl's $/ more idiomatically