Re: Remove support for Visual Studio 2013

On Mon, May 16, 2022 at 8:58 AM Michael Paquier <michael@paquier.xyz> wrote:

>
> The patch attached cleans up the following things proper to VS 2013:
> - Locale handling.
> - MIN_WINNT assignment.
> - Some strtof() business, as of win32_port.h.
> - Removal of _set_FMA3_enable() in main.c related to floating-point
> operations.
> - MSVC scripts, but that's less interesting considering the work done
> with meson.
>
> When building on MinGW with NLS enabled I get some errors:

c:/cirrus/src/backend/utils/adt/pg_locale.c: In function
'search_locale_enum':
c:/cirrus/src/backend/utils/adt/pg_locale.c:989:13: warning: implicit
declaration of function 'GetLocaleInfoEx'; did you mean 'GetLocaleInfoA'?
[-Wimplicit-function-declaration]
  989 |         if (GetLocaleInfoEx(pStr, LOCALE_SENGLISHLANGUAGENAME,
      |             ^~~~~~~~~~~~~~~
      |             GetLocaleInfoA

This is because current MinGW defaults to Windows 2003 [1], maybe we should
fix Windows' minimal version to Vista (0x0600) unconditionally also. I have
seen a couple of compilation warnings while testing that setting on MinGW,
please find attached a patch for so.

[1]
https://github.com/mirror/mingw-w64/blob/master/mingw-w64-headers/include/sdkddkver.h

Regards,

Juan José Santamaría Flecha