Horton

Re: logical decoding : exceeded maxAllocatedDescs for .spill files

Juan José Santamaría Flecha <juanjo.santamaria@gmail.com>

View thread
From: Juan José Santamaría Flecha <juanjo.santamaria@gmail.com>
To: Amit Kapila <amit.kapila16@gmail.com>
Cc: Amit Khandekar <amitdkhan.pg@gmail.com>, Andres Freund <andres@anarazel.de>, Tom Lane <tgl@sss.pgh.pa.us>, Thomas Munro <thomas.munro@gmail.com>, Robert Haas <robertmhaas@gmail.com>, Tomas Vondra <tomas.vondra@2ndquadrant.com>, Alvaro Herrera from 2ndQuadrant <alvherre@alvh.no-ip.org>, PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Date: 2019-11-21T15:02:18Z
Lists: pgsql-hackers

Commits

Same data as JSON: GET /api/v1/messages/:b64id/commits the thread's linked commits as JSON, with link sources. API reference →

  1. When a TAP file has non-zero exit status, retain temporary directories.

  2. Fix running out of file descriptors for spill files.

  3. Track statistics for spilling of changes from ReorderBuffer.

  4. Handle ReadFile() EOF correctly on Windows.

  5. Add logical_decoding_work_mem to limit ReorderBuffer memory usage.

  6. Generational memory allocator

  7. Support retaining data dirs on successful TAP tests

On Thu, Nov 21, 2019 at 5:02 AM Amit Kapila <amit.kapila16@gmail.com> wrote:

> On Wed, Nov 20, 2019 at 5:41 PM Juan José Santamaría Flecha
> <juanjo.santamaria@gmail.com> wrote:
> >
> > On Wed, Nov 20, 2019 at 9:48 AM Amit Khandekar <amitdkhan.pg@gmail.com>
> wrote:
> >>
> >> On Wed, 20 Nov 2019 at 13:10, Amit Kapila <amit.kapila16@gmail.com>
> wrote:
> >> > See comment in pgunlink() "We need to loop because even though
> >> > PostgreSQL uses flags that allow unlink while the file is open, other
> >> > applications might have the file
> >> > open without those flags.".  Can you once see if there is any flag
> >> > that you have missed to pass to allow this?
> >>
> >> > If there is nothing we
> >> > can do about it, then we might need to use some different API or maybe
> >> > define a new API that can handle this.
> >>
> >> There were objections against modifying the vfd api only for this
> >> replication-related use-case. Having a new API will require all the
> >> changes required to enable the virtual FDs feature that we need from
> >> vfd. If nothing works out from the FILE_SHARE_DELETE thing, I am
> >> thinking, we can use VFD, plus we can keep track of per-subtransaction
> >> vfd handles, and do something similar to AtEOSubXact_Files().
> >>
> >
> > The comment about "other applications might have the file open without
> those flags." is surely due to systems working with an antivirus touching
> Postgres files.
> >
> > I was not able to reproduce the Permission denied error with current
> HEAD,
> >
>
> I am not sure what exactly you tried.  Can you share the steps and
> your environment details?
>
>
Sure, I was trying to reproduce the Permission denied error after
the ERROR_HANDLE_EOF fix.

1. Using a clean environment [1] the spill.sql script produces the expected
output.
2. I manually injected a negative value for readBytes after @@ -2611,10
+2627,11 @@ ReorderBufferRestoreChanges(ReorderBuffer *rb, ReorderBufferTXN
*txn. In doing so pg_logical_slot_get_changes() failed, but following
executions did not run into Permission denied.
3. During the cleanup of some of the tests, pg_drop_replication_slot()
failed because the "pg_replslot/regression_slot" folder was is use.

[1] Win10 (1903) MSVC 19.22.27905

Regards,

Juan José Santamaría Flecha