Horton

Re: BUG #16161: pg_ctl stop fails sometimes (on Windows)

Juan José Santamaría Flecha <juanjo.santamaria@gmail.com>

View thread View on postgr.es
From: Juan José Santamaría Flecha <juanjo.santamaria@gmail.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Alexander Lakhin <exclusion@gmail.com>, Kyotaro Horiguchi <horikyota.ntt@gmail.com>, PostgreSQL mailing lists <pgsql-bugs@lists.postgresql.org>
Date: 2019-12-19T20:49:54Z
Lists: pgsql-bugs 
On Thu, Dec 19, 2019 at 9:09 PM Tom Lane <tgl@sss.pgh.pa.us> wrote:

>
> > It seems that the check for ERROR_DELETE_PENDING was added to
> > pgwin32_safestat() blindly, the issue wasn't reproduced at that time:
> >
> https://www.postgresql.org/message-id/CAB7nPqRJV6trFta-Qzgi6j2feuYR2ZC%2BKHvWdHnbpDG2scTrxw%40mail.gmail.com
>
> Hmm, makes one wonder whether that's actually live code.
>
>
Part of what the patch "Windows could not stat file - over 4GB" [1] does is
proposing an alternative using native functions.

[1] https://commitfest.postgresql.org/26/2189/

Regards,

Juan José Santamaría Flecha

Commits

  1. In pgwin32_open, loop after ERROR_ACCESS_DENIED only if we can't stat.

  2. On Windows, wait a little to see if ERROR_ACCESS_DENIED goes away.